Avoid sending an unnecessary "clear diagnostics" message for clients supporting pull diagnostics#21105
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Oct 28, 2025
Conversation
Contributor
|
MichaReiser
changed the title
ruff] Add capabilities check for clear_diagnostics_for_document
Member
|
Ahh... airplane wifi at its best. |
TaKO8Ki
deleted the
capabilities-check-for-clear_diagnostics_for_document
branch
dcreager
added a commit
that referenced
this pull request
Oct 28, 2025
…straint-sets * dcreager/subtype-given-typevars: better comment restructure a bit better names/comments simplify before implication two typevars! [ty] Reformat constraint set mdtests (#21111) [ty] Move constraint set mdtest functions into `ConstraintSet` class (#21108) Avoid sending an unnecessary "clear diagnostics" message for clients supporting pull diagnostics (#21105) Update Rust crate ignore to v0.4.24 (#20979)
Member
|
This breaks notebook support. Notebooks only support publish diagnostics. I'll revert it for now |
Contributor
Author
|
@MichaReiser Ok. I will create a pull request with necessary fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20784
Move the capability check into
publish_diagnostics_for_documentandclear_diagnostics_for_document.Test Plan
I have tested it with VSCode.